Animate the Cloud Mode viewer session-loading indicator - #15546
Open
warp-agent-staging[bot] wants to merge 1 commit into
Open
Animate the Cloud Mode viewer session-loading indicator#15546warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Replace the static refresh icon shown while a shared session viewer or conversation transcript is loading with the shimmering Warp loading text used elsewhere in the app (e.g. the remote server loading footer), so the loading state is clearly animating.
Contributor
Author
|
This PR was generated with Warp. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The Cloud Mode / shared-session viewer loading indicator (
TerminalView::render_viewer_loading, shown while a shared session viewer or a conversation transcript is loading) was a staticrefresh.svgicon and "Loading session..." text — nothing animated, making it unclear the session was actively loading.This replaces the static icon + text with
shimmering_warp_loading_text, the shimmering-text loading indicator already used elsewhere in the app for the same purpose (e.g. the remote-server loading footer, the cloud mode agent loading screen). The indicator now animates continuously while loading and disappears once loading completes, reusing the existingShimmeringTextElementanimation/repaint plumbing rather than hand-rolling a new one.Reported directly in Slack (no tracked issue): https://warpdev.slack.com/archives/C0BDQDW8V5E/p1787693813417159
Linked Issue
Testing
This is a pure animation/visual change with no new branching logic, so no automated test was added (exempt as a visual/copy-adjacent change per repo conventions).
Verified with
cargo check -p warp --lib(compiles cleanly),cargo clippy -p warp --lib -- -D warnings(clean), andcargo fmt -p warp -- --check(clean).Visually verified by driving a
TerminalViewinto the exact "loading conversation transcript" state that renders this indicator (via the existing productionPaneGroup::add_loading_conversation_paneAPI, never resolved with real data) inside the repo'scrates/integrationreal-display recording harness, and recording it. The recording confirms the "Loading session..." text shimmers continuously (highlight sweeping across the text) rather than staying static. This verification scaffolding was not committed.Screenshots / Videos
The recording below shows the shimmer animation sweeping across the "Loading session..." text.
Computer-use video recordings
View video recording - Recording showing the animated (shimmering) "Loading session..." indicator in the Cloud Mode / shared-session viewer loading state, captured via the crates/integration real-display test harness by driving TerminalModel into the loading-conversation-transcript state through the existing production PaneGroup::add_loading_conversation_pane API (no test-only production code added).
Agent Mode
CHANGELOG-IMPROVEMENT: The Cloud Mode session-loading indicator now animates to make it clearer that a session is loading.