mcp: proactively re-mint managed proxy tokens before expiry during agent runs - #15539
Conversation
This was referenced Aug 25, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 25, 2026
mcp: re-mint expired managed proxy tokens on demand instead of failing or misrouting to OAuth
#15538
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The previous PR heals an expired token reactively (first failed call pays a reconnect round-trip). For long agent runs we can do better: the mutation's
expires_attells us exactly when the token dies, and re-minting early is cheap and overlap-safe.Changes
expires_atper managed installation (previously a dead field on the mutation output).managed_mcp_refresh::refresh_loop, raced as a thirdselect!arm inwith_credential_refreshes(same pattern as the git/Bedrock credential loops — never resolves, dropped when the run finishes): sleeps until 5 minutes before the earliest expiry (never spinning faster than 60s), re-mints due entries with the full startup retry budget, and respawns via the newTemplatableMCPServerManager::respawn_with_installation— which skips the refresher (config is pre-refreshed) and defers to any reactive reconnect already in flight.Known trade-off (accepted): a proactive respawn tears down the live transport; a tool call in flight at that instant gets
TransportClosedand is retried once against the fresh connection byReconnectingPeer.Flag-gated by
McpSelfHeal(the loop is only armed when managed entries with expirations exist).Tests
Schedule math (wake at expiry−lead, 60s clamp for due/past tokens, due-window boundaries) plus a resolution test asserting
expires_atis captured into the schedule.