fix: align floating overlays at app zoom - #22
Conversation
|
Thanks for this - genuinely nice work. The diagnosis is spot on (Floating UI computing viewport coordinates while the portal lives inside the zoomed That said, I'm not going to merge it, and it's worth explaining why. As noted at the top of the README, this project's active development has moved to PaiR. The Beads Task-Issue Tracker is frozen at the last meaningful CLI version it supports ( None of that stops you from carrying the fix yourself: you already have it in So this isn't a reflection on the quality of the PR (which is high) - it's the project status. And if this rendering issue also exists in PaiR, I'd be very happy to look at the same fix over there. Thanks again for taking the time to do it properly. |
|
@w3dev33 NP I totally agree with your comment. I hadn't looked at PaiR before last night. I think it has have a similar defect |
Summary
Fixes #21
Desktop floating overlays drift right when application zoom is increased above approximately 115%. The issue occurs because Reka/Floating UI computes fixed-position coordinates in viewport space while the portal is rendered inside the zoomed
#zoomable-contentsubtree.Changes
#floating-overlay-rootoutside the zoomed application content.Verification
The type checker still reports two pre-existing
bdAPI typing errors inserver/api/bd/list.get.tsandserver/api/bd/ready.get.ts.