Only generate an attribute prefix if required - #30
Open
bwrrp wants to merge 1 commit into
Open
Conversation
If implemented as specified, the prefix set for an attribute in the DOM would never be preserved during serialization. This change only generates the new prefix if the prefix is either missing (which is not allowed for namespaced attributes), or if it conflicts with another local namespace definition of the prefix for a different namespace. Fixes w3c#29
bwrrp
force-pushed
the
preserve-attribute-prefixes
branch
from
October 31, 2018 11:13
eae9f35 to
97e7bb3
Compare
|
This seems to still be buggy, as only new prefix is set, and candidate prefix remains null, so the step below will not serialize any prefix: let root = parse('<r></r>');
root.setAttributeNS('uri', 'p:name', 'value');
serialize(root) // '<r xmlns:ns1="uri" name="value"/>'(I'm integrating a fix elsewhere, no need to update this PR.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If implemented as specified, the prefix set for an attribute in the DOM would never be preserved during serialization. This change only generates the new prefix if the prefix is either missing (which is not allowed for namespaced attributes), or if it conflicts with another local namespace definition of the prefix for a different namespace.
Fixes #29