Skip to content

fix: honor reminder job cancellation - #164

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/reminders-job-cancellation-20260824
Open

fix: honor reminder job cancellation#164
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/reminders-job-cancellation-20260824

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • propagate Quartz cancellation through reminder loading, per-reminder processing, and persistence
  • add a regression test proving pre-canceled reminder runs stop before database work

Verification

  • dotnet build --no-restore — passed with 0 warnings and 0 errors
  • dotnet test --no-restore --filter FullyQualifiedName~RemindersJobTests — passed, 12/12 tests
  • dotnet test --no-restore --filter 'FullyQualifiedName!~McpCommandExecutionTests.Invocation_ValidatesLocaleAndTimeZoneContext' — passed, 503 passed and 1 skipped
  • dotnet test --no-restore — 503 passed, 1 skipped, and 1 unrelated pre-existing failure because this runner forces globalization-invariant mode and cannot resolve en-US
  • git diff --check — passed

Risk

  • Low: cancellation now stops remaining reminder processing and prevents a canceled save; normal runs are unchanged.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant