fix(#2591): expose defineExpose bindings on findComponent vm - #2927
Open
adamberecz wants to merge 1 commit into
Open
fix(#2591): expose defineExpose bindings on findComponent vm#2927adamberecz wants to merge 1 commit into
adamberecz wants to merge 1 commit into
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findComponent()now returnsdefineExpose()/expose()bindings onvmfor bundled-style components (setup that returns a render function). Vue only createsexposeProxylazily (template ref or directive), so a child can have an exposed API whileexposeProxyis stillnull.devtoolsRawSetupStateis missing, which is the typical bundled<script setup>case.findComponentdoesn't not return exposed properties in vm if component is bundled #2591 plus coverage forexposeProxy === null.This supersedes #2715.
Fixes #2591
Test plan
pnpm test— includes bundled-stylefindComponentcase and null-exposeProxycasespnpm run lint/format-check/test:build/tsd/vue-tsc/tsc:docsMade with Cursor