fix: trigger button click from keyboard activation - #2926
Open
rajanpanth wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2545.
wrapper.trigger('keydown.enter')andwrapper.trigger('keydown.space')now synthesize the browser-style click activation for enabled<button>elements. The synthesized click is only dispatched if the keydown event is not canceled, so handlers using.preventcan suppress activation like they do in the browser.Validation
corepack pnpm vitest run tests/trigger.spec.tscorepack pnpm exec oxfmt --check src/baseWrapper.ts tests/trigger.spec.tscorepack pnpm exec oxlint src/baseWrapper.ts tests/trigger.spec.ts(exits 0; existing warning-only findings remain in the file)corepack pnpm run buildgit diff --check