Expose generic fallback span tags - #671
Open
vmourac-vtex wants to merge 2 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Downstream draft gateway integration: https://github.com/vtex/graphql-server/pull/351. It remains blocked on this SDK PR and publication of @vtex/api@7.5.0. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is the purpose of this pull request?
Expose a generic API for adding attributes to the existing fallback request span.
What problem is this solving?
Application middleware cannot currently enrich the incoming fallback span after
ctx.tracingis cleared.How should this be manually tested?
Run
yarn lint,yarn test --runInBand, andyarn ci:build.Screenshots or example usage
Not applicable.
Types of changes