Skip to content

Expose generic fallback span tags - #671

Open
vmourac-vtex wants to merge 2 commits into
masterfrom
feat/fallback-span-tags
Open

Expose generic fallback span tags#671
vmourac-vtex wants to merge 2 commits into
masterfrom
feat/fallback-span-tags

Conversation

@vmourac-vtex

Copy link
Copy Markdown

What is the purpose of this pull request?

Expose a generic API for adding attributes to the existing fallback request span.

What problem is this solving?

Application middleware cannot currently enrich the incoming fallback span after ctx.tracing is cleared.

How should this be manually tested?

Run yarn lint, yarn test --runInBand, and yarn ci:build.

Screenshots or example usage

Not applicable.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

vmourac-vtex and others added 2 commits July 28, 2026 00:52
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@sonar-workflows

Copy link
Copy Markdown

Failed Quality Gate failed

  • 315 New Issues (is greater than 0)
  • 30.60% Coverage on New Code (is less than 75.00%)
  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)
  • D Reliability Rating on New Code (is worse than A)

Project ID: node-vtex-api

View in SonarQube

@vmourac-vtex

Copy link
Copy Markdown
Author

Downstream draft gateway integration: https://github.com/vtex/graphql-server/pull/351. It remains blocked on this SDK PR and publication of @vtex/api@7.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant