Repository navigation
chore(deps): depend on bun-types directly instead of @types/bun - #25
Conversation
@types/bun is a one-line stub (`/// <reference types="bun-types" />`) that Socket scores at 47 for quality. bun-types holds the actual declarations and scores 84, so depend on it directly and point the tsconfig `types` arrays at it. The resolved types are unchanged.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. WalkthroughThe root development dependency changes from ChangesBun type package update
Estimated code review effort: 2 (Simple) | ~7 minutes Possibly related PRs
Merge Risk:
|
# Conflicts: # bun.lock # package.json
Closes #27
Summary
@types/bunis a stub package. Its wholeindex.d.tsis/// <reference types="bun-types" />, and it depends onbun-types, which holds the actual declarations. Socket scores the stub low:@types/bun@1.4.4bun-types@1.4.4This replaces the root dev dependency
@types/bunwithbun-types@^1.4.4and changes"types": ["bun"]to["bun-types"]in everytsconfig.jsonthat used it (six packages plussites/docs). The resolved types are the same; only the indirection goes away.The License score drops to 70 because of the copyleft flag on
bun-types. The repo already depended onbun-typesthrough@types/bun, so this exposure isn't new.This is independent of #24. Whichever merges second needs a
bun.lockrebase.Testing
Removed the leftover
node_modules/@types/bunbefore testing so it couldn't hide a missing reference.bun run typecheck,bun run testandbun run checkall pass.Summary by cubic
Swaps the
@types/bunstub dependency forbun-typesdirectly.@types/bunis a one-line reference stub (/// <reference types="bun-types" />) that Socket scores at 47 for quality, whilebun-typesholds the actual declarations and scores 84. The resolved types are unchanged; only the indirection is removed.devDependenciesand thetypesarray in seventsconfig.jsonfiles from"bun"to"bun-types".bun-types's copyleft flag drops the Socket license score to 70, but the repo already depended on it through@types/bun, so the exposure isn't new.Written for commit 13d1623. Summary will update on new commits.
Summary by CodeRabbit
bun-typesdefinitions consistently across packages and documentation.