Teach ArrayVTable about capabilities and let arrays provide extensible capabilities - #9371
Open
robert3005 wants to merge 1 commit into
Open
Teach ArrayVTable about capabilities and let arrays provide extensible capabilities#9371robert3005 wants to merge 1 commit into
robert3005 wants to merge 1 commit into
Conversation
Merging this PR will improve performance by 11.71%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
robert3005
force-pushed
the
rk/array-capabilities
branch
from
August 11, 2026 23:35
16976b0 to
b7d5cdb
Compare
…e capabilities execute_until and Matchers provide us a mechanism for unwrapping an array tree into a known set of encodings. The Matcher is defined statically and cannot be extended if it is used as part of another mechanism. Here we introduce a way for arrays to claim the capabilities they provide, and let matchers use them as a match condition. VarBinExportable is the first such capability: it marks encodings whose append_to_builder writes byte values straight into a VarBinBuilder, which a later change uses to stop Arrow export before it canonicalizes them. Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
force-pushed
the
rk/array-capabilities
branch
from
August 11, 2026 23:38
b7d5cdb to
c13f3f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute_untilandMatchergive us a mechanism for unwrapping an array tree into a known set of encodings. AMatcheris defined statically, though, so it cannot be extended when it is used as part of another mechanism — an out-of-crate encoding has no way to join the set.This PR lets arrays claim the capabilities they provide, and lets matchers use a capability as their match condition.