Skip to content

Validate names and dtypes equal length on struct flatbuffer parse - #9362

Open
myrrc wants to merge 1 commit into
developfrom
myrrc/fix-8849
Open

Validate names and dtypes equal length on struct flatbuffer parse#9362
myrrc wants to merge 1 commit into
developfrom
myrrc/fix-8849

Conversation

@myrrc

@myrrc myrrc commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Resolves: #8849

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc added the changelog/fix A bug fix label Aug 11, 2026
@myrrc
myrrc enabled auto-merge (squash) August 11, 2026 17:25
@codspeed-hq

codspeed-hq Bot commented Aug 11, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 20.47%

⚡ 4 improved benchmarks
✅ 1958 untouched benchmarks
⏩ 89 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation search_index_in_range_chunked 6.6 ms 5.2 ms +25.99%
Simulation take[core/shuffled/primitive/nonnull/chunks=1024/indices=10000] 14.7 ms 12.1 ms +20.96%
Simulation cold_misaligned[(64, 256)] 5.1 ms 4.4 ms +17.67%
Simulation search_index_above_max_chunked 5.4 ms 4.6 ms +17.44%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/fix-8849 (5f79c6d) with develop (1b34a5e)2

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (ca7f626) during the generation of this report, so 1b34a5e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in StructFields::from_fields() on malformed file: length mismatch between names and dtypes

2 participants