Skip to content

Allow Timestamp outside of jiff's range - #9361

Open
myrrc wants to merge 1 commit into
developfrom
myrrc/fix-8860
Open

Allow Timestamp outside of jiff's range#9361
myrrc wants to merge 1 commit into
developfrom
myrrc/fix-8860

Conversation

@myrrc

@myrrc myrrc commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Writing Arrow-valid timestamp that's out of jiff range did panic.
Don't validate the timestamp, and change construction, including display,
to return an error instead of panicking.

Resolves: #8860

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc added the changelog/fix A bug fix label Aug 11, 2026
@myrrc
myrrc enabled auto-merge (squash) August 11, 2026 17:22
@codspeed-hq

codspeed-hq Bot commented Aug 11, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.99%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 6 regressed benchmarks
✅ 1953 untouched benchmarks
⏩ 89 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take[small_m/shuffled/primitive/nonnull/chunks=1024/indices=1000] 5.6 ms 6.7 ms -16.62%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=1024/indices=256] 2.1 ms 2.5 ms -15.79%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=16384/indices=1000] 9.6 ms 11.2 ms -14.77%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=16384/indices=256] 3.2 ms 3.6 ms -11.84%
Simulation compact[(4096, 90)] 1.7 µs 1.9 µs -10.51%
Simulation compact_sliced[(4096, 90)] 1.8 µs 2 µs -10.16%
Simulation search_index_in_range_chunked 6.6 ms 5.4 ms +21.31%
Simulation cold_misaligned[(64, 256)] 5.1 ms 4.4 ms +17.75%
Simulation search_index_above_max_chunked 5.4 ms 4.7 ms +14.45%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/fix-8860 (61ea323) with develop (1b34a5e)2

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (ca7f626) during the generation of this report, so 1b34a5e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@myrrc myrrc changed the title don't validate Timestamp with jiff Allow Timestamp outside of jiff's range Aug 11, 2026

@robert3005 robert3005 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Scalar::extension_ref wrong? I think the fix here is that it's correct instead of not using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Writing a Timestamp in the last ~26h of year 9999 panics during Min/Max stats

2 participants