Skip to content

fix(spark): name the Vortex files when a read fails #9326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 1 commit into from
Aug 11, 2026
Merged

fix(spark): name the Vortex files when a read fails #9326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions java/vortex-spark/src/main/java/dev/vortex/spark/read/VortexPartitionReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public boolean next() {
return true;
}
} catch (IOException e) {
throw new RuntimeException(e);
throw failure("load a batch from", e);
}
closeCurrentReader();
}
Expand All @@ -119,7 +119,7 @@ public ColumnarBatch get() {
try {
root = currentReader.getVectorSchemaRoot();
} catch (IOException e) {
throw new RuntimeException(e);
throw failure("read the loaded batch of", e);
}

int rowCount = root.getRowCount();
Expand Down Expand Up @@ -157,12 +157,17 @@ public void close() {
session = null;
}

/** Wraps a failure with the paths being read, the one fact a stack trace alone does not give. */
private RuntimeException failure(String what, IOException cause) {
return new RuntimeException(String.format("Failed to %s %s", what, spark.paths()), cause);
}

private void closeCurrentReader() {
if (currentReader != null) {
try {
currentReader.close();
} catch (IOException e) {
throw new RuntimeException(e);
throw failure("close the reader over", e);
}
currentReader = null;
}
Expand Down
Loading