feat(vortex-spatial): add area scalar function - #9203
Conversation
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | cold_misaligned[(64, 256)] |
4.4 ms | 5.3 ms | -16.88% |
| ⚡ | Simulation | decompress[u64, (1000, 16)] |
73.6 µs | 65 µs | +13.16% |
| ⚡ | Simulation | compress_fsst[(1000, 64, 8)] |
1.2 ms | 1 ms | +13.04% |
| 🆕 | Simulation | column_x_column |
N/A | 212.7 µs | N/A |
| 🆕 | Simulation | column_x_constant |
N/A | 586.6 µs | N/A |
| 🆕 | Simulation | nullable_columns |
N/A | 234.6 µs | N/A |
| 🆕 | Simulation | multipolygon |
N/A | 2.7 ms | N/A |
| 🆕 | Simulation | nullable_polygon |
N/A | 1.4 ms | N/A |
| 🆕 | Simulation | polygon_with_holes |
N/A | 2.3 ms | N/A |
| 🆕 | Simulation | simple_polygon |
N/A | 1 ms | N/A |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing nemo/geo-area (0f145ec) with develop (9157d6c)2
Footnotes
-
89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(c61095f) during the generation of this report, so 9157d6c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
9ba67c9 to
ecd0e75
Compare
ecd0e75 to
13646f3
Compare
13646f3 to
0ab5a9b
Compare
0ab5a9b to
7040417
Compare
7040417 to
c6fd58a
Compare
40f4666 to
90ee99b
Compare
90ee99b to
ae32ab5
Compare
ae32ab5 to
1d9bf5e
Compare
1d9bf5e to
a7e9fe3
Compare
a7e9fe3 to
6a77d49
Compare
6a77d49 to
d9149fe
Compare
d9149fe to
2980eb4
Compare
connortsui20
left a comment
There was a problem hiding this comment.
I really need to get my rowfn stuff in
2980eb4 to
3292e7f
Compare
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
3292e7f to
0f145ec
Compare
Summary
GeoAreascalar function backed bygeo::Area::unsigned_arearstestfor clearer per-dtype failures and broader operand-order coverageSemantics
This follows DuckDB
ST_Areasemantics over the native Vortex geometry types: point and line families return zero, polygon holes are subtracted, multipolygon component areas are summed, rectangles use width times height, and higher coordinate dimensions are ignored. WKB remains excluded because it is a storage representation rather than a native decoded geometry.