Repository navigation
[bench only] #10708 on develop - #10759
joseph-isaacs wants to merge 3 commits into
Conversation
451ce0b to
2ad5d83
Compare
Polar Signals Profiling ResultsLatest Run
Previous Runs (14)
Powered by Polar Signals Cloud |
Benchmarks: PolarSignals Profiling 📖Commits: PR datafusion / vortex-file-compressed / ns (0.990x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: FineWeb NVMe 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.026x ➖, 0↑ 2↓)
datafusion / parquet / ns (1.004x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.997x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.982x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-H SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.094x ➖, 0↑ 6↓)
datafusion / parquet / ns (1.002x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.987x ➖, 1↑ 0↓)
duckdb / parquet / ns (0.998x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-H SF=10 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.024x ➖, 0↑ 1↓)
datafusion / parquet / ns (0.998x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.999x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.997x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: Clickbench on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.999x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.997x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.003x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.012x ➖, 1↑ 1↓)
No file size changes detected. |
Benchmarks: TPC-DS SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.004x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.999x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.001x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.998x ➖, 1↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-H SF=1 on S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.014x ➖, 1↑ 3↓)
datafusion / parquet / ns (1.028x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.040x ➖, 0↑ 1↓)
duckdb / parquet / ns (0.982x ➖, 0↑ 1↓)
|
Merging this PR will regress 1 benchmark3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
The failing CodSpeed Performance Analysis check is not caused by this PR's diff:
No fix is needed in this benchmark-only PR. Its purpose was the SQL benchmark run, which has completed. Generated by Claude Code |
The net change of #10708 (ji/scan-v2-chain-3-drivers at 25458e3, which includes the #10707 commits it stacks on) applied onto develop as one commit, for benchmarking only. Conflicts with develop are resolved by keeping both sides: the new Eval(pack)/Eval(Eval) rules sit beside the zoned-data rule, plan rules and `optimize` take the session, and the legacy-stats tests expect develop's packed zone conversion. Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KbaPHjo8XVLKjhGy9xoUMC
2ad5d83 to
c71db2e
Compare
Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KbaPHjo8XVLKjhGy9xoUMC
Adds `tpch-s3-10` to the `pr` preset at the default targets, for this benchmark-only PR. Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KbaPHjo8XVLKjhGy9xoUMC
|
License Check and Audit Check (advisories) fails on
Both fixes are semver-major upgrades, and Generated by Claude Code |
Benchmarks: TPC-H SF=10 on S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.932x ➖, 4↑ 4↓)
datafusion / parquet / ns (0.910x ➖, 3↑ 0↓)
duckdb / vortex-file-compressed / ns (1.058x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.057x ➖, 2↑ 1↓)
|
Summary
Benchmark-only draft, not for merging. It now holds #10708 rebased onto
develop(e5a4e66), to see whether #10708 recovers the TPC-H SF=1 DataFusion hot-run regression that #10707 introduced. #10708 targets #10707's branch, so it can't get anaction/bench-sqlrun itself.The previous run on this PR measured #10707 plus a concurrency-default fix (
2ad5d83), see the benchmark comments above:Changes
c71db2eis #10708's net change (ji/scan-v2-chain-3-driversat25458e3, including the #10707 commits it stacks on) applied ontodevelopas one commit.Conflicts with
developare resolved by keeping both sides:EvalPackRule/EvalEvalRulerules sit beside Compose and drive a V2 scan in DataFusion #10708'sZonedDataRule.optimizetake the session.develop'sPackzone conversion.The concurrency-default fix is not included. On its own it didn't change the TPC-H result.
Checks:
cargo check -p vortex-layout -p vortex-scan -p vortex-file -p vortex-datafusion --all-targetspasses.cargo test -p vortex-layout --lib -- plan::physical scan::v2 scan::executionpasses (212 tests).🤖 Generated with Claude Code
https://claude.ai/code/session_01KbaPHjo8XVLKjhGy9xoUMC