Repository navigation
chore: fix intermittent failure in fused_decode_is_wrapping_add - #10544
Conversation
Signed-off-by: mightsleep <acannix@proton.me>
robert3005
left a comment
There was a problem hiding this comment.
Thanks, I had it on one of the branches but good to merge it separately
Merging this PR will improve performance by 34.3%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ |
Simulation | density_sweep_dense_runs[0.001] |
46.9 µs | 29.3 µs | +59.95% |
| ⚡ | WallTime | threshold_avx2[80] |
3 µs | 2.6 µs | +12.76% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mightsleep:chore/fused-decode-test (c07b79a) with develop (c48fa1b)2
Footnotes
-
12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(c677922) during the generation of this report, so c48fa1b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Summary
fused_decode_is_wrapping_adddraws each block's width from0..=native, so every block can come out at the native width (a single u8 block draws 8 about one time in nine). Since #10203,encode_blockedrejects that ("Cannot pack: all blocks use the native bit width"). CI derandomizes hegel and its fixed seed happens to pass, but my local runs with a random seed fail in ~ half of the runs (7 of 20 here), and once the failure is in.hegel/it replays on every run.Changes
When every drawn width is native, the first block drops to
native - 1; the rest of the draw is unchanged.Checked with
cargo test -p vortex-fastlanes --lib -- for_::(3 runs, 107/107).