Skip to content

perf(datafusion): avoid Arrow session lookup for ordinary scalars #10541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-isaacs merged 1 commit into from
Oct 16, 2026
Merged

perf(datafusion): avoid Arrow session lookup for ordinary scalars #10541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions vortex-datafusion/src/convert/scalars.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ impl TryToDataFusion<ScalarValue> for Scalar {
/// Converts a DataFusion [`ScalarValue`] to a Vortex [`Scalar`], resolving Arrow types through
/// `session`'s [`ArrowSession`](vortex_arrow::ArrowSession).
pub fn scalar_from_df(value: &ScalarValue, session: &VortexSession) -> VortexResult<Scalar> {
let arrow = session.arrow();
Ok(match value {
ScalarValue::Null => Scalar::null(DType::Null),
ScalarValue::Boolean(b) => b
Expand Down Expand Up @@ -241,7 +240,8 @@ pub fn scalar_from_df(value: &ScalarValue, session: &VortexSession) -> VortexRes
ScalarValue::Date32(v)
| ScalarValue::Time32Second(v)
| ScalarValue::Time32Millisecond(v) => {
let dtype = arrow
let dtype = session
.arrow()
.from_arrow_datatype(&value.data_type(), Nullability::Nullable)
.vortex_expect("arrow data type to dtype");
Scalar::try_new(dtype, v.map(vortex::scalar::ScalarValue::from))
Expand All @@ -254,7 +254,8 @@ pub fn scalar_from_df(value: &ScalarValue, session: &VortexSession) -> VortexRes
| ScalarValue::TimestampMillisecond(v, _)
| ScalarValue::TimestampMicrosecond(v, _)
| ScalarValue::TimestampNanosecond(v, _) => {
let dtype = arrow
let dtype = session
.arrow()
.from_arrow_datatype(&value.data_type(), Nullability::Nullable)
.vortex_expect("arrow data type to dtype");
Scalar::try_new(dtype, v.map(vortex::scalar::ScalarValue::from))
Expand Down
Loading