Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions frontend/src/ui/SessionCapabilityDialogs.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import { useEffect, useMemo, useRef, useState, type ReactNode } from "react";
import { createPortal } from "react-dom";
import {
listSessionSkillsInSpace,
listSessionSkillSpaces,
searchSessionPublicSkills,
type AddSessionCapability,
type SessionPublicSkill,
type SessionSkillCatalogItem,
type SessionSkillSpace,
} from "../adk/client";
import {
listSkillsInSpace,
listSkillSpaces,
type SkillSpaceRef,
type SkillSpaceSkill,
} from "../create/skills/skillspace";
import { BUILTIN_TOOLS } from "../create/veadkCatalog";
import { ToolCapabilityIcon } from "./CapabilityIcons";

Expand Down Expand Up @@ -255,9 +257,9 @@ export function SkillCapabilityDialog({
const [publicTotal, setPublicTotal] = useState(0);
const [publicLoading, setPublicLoading] = useState(true);
const [publicError, setPublicError] = useState("");
const [spaces, setSpaces] = useState<SessionSkillSpace[]>([]);
const [selectedSpace, setSelectedSpace] = useState<SessionSkillSpace | null>(null);
const [skills, setSkills] = useState<SessionSkillCatalogItem[]>([]);
const [spaces, setSpaces] = useState<SkillSpaceRef[]>([]);
const [selectedSpace, setSelectedSpace] = useState<SkillSpaceRef | null>(null);
const [skills, setSkills] = useState<SkillSpaceSkill[]>([]);
const [spaceQuery, setSpaceQuery] = useState("");
const [skillQuery, setSkillQuery] = useState("");
const [spacesLoading, setSpacesLoading] = useState(true);
Expand Down Expand Up @@ -299,7 +301,7 @@ export function SkillCapabilityDialog({
let active = true;
setSpacesLoading(true);
setError("");
void listSessionSkillSpaces(appName)
void listSkillSpaces()
.then((items) => {
if (!active) return;
setSpaces(items);
Expand All @@ -312,7 +314,7 @@ export function SkillCapabilityDialog({
if (active) setSpacesLoading(false);
});
return () => { active = false; };
}, [appName, sourceTab]);
}, [sourceTab]);

useEffect(() => {
if (sourceTab !== "agentkit") return;
Expand All @@ -323,7 +325,7 @@ export function SkillCapabilityDialog({
let active = true;
setSkillsLoading(true);
setError("");
void listSessionSkillsInSpace(appName, selectedSpace.id, selectedSpace.region)
void listSkillsInSpace(selectedSpace.id, selectedSpace.region)
.then((items) => {
if (active) setSkills(items);
})
Expand All @@ -334,7 +336,7 @@ export function SkillCapabilityDialog({
if (active) setSkillsLoading(false);
});
return () => { active = false; };
}, [appName, selectedSpace, sourceTab]);
}, [selectedSpace, sourceTab]);

const filteredSpaces = useMemo(() => {
const normalized = spaceQuery.trim().toLowerCase();
Expand All @@ -352,7 +354,7 @@ export function SkillCapabilityDialog({
);
}, [skillQuery, skills]);

const addSkill = async (skill: SessionSkillCatalogItem) => {
const addSkill = async (skill: SkillSpaceSkill) => {
if (!selectedSpace) return;
setPending(skill.skillId);
const added = await onAdd({
Expand Down
14 changes: 12 additions & 2 deletions frontend/tests/agentInfoRail.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ const clientSource = readFileSync(
new URL("../src/adk/client.ts", import.meta.url),
"utf8",
);
const skillspaceClientSource = readFileSync(
new URL("../src/create/skills/skillspace.ts", import.meta.url),
"utf8",
);
const navbarSource = readFileSync(
new URL("../src/ui/Navbar.tsx", import.meta.url),
"utf8",
Expand Down Expand Up @@ -235,8 +239,14 @@ test("uses searchable dialogs for public Skill Hub and AgentKit Skill Center", (
assert.match(capabilityDialogsSource, /searchSessionPublicSkills\(appName, publicQuery\.trim\(\)\)/);
assert.match(capabilityDialogsSource, /skillSourceId: `findskill:\$\{skill\.slug\}`/);
assert.match(clientSource, /\/harness\/skills\/findskill/);
assert.match(capabilityDialogsSource, /listSessionSkillSpaces\(appName\)/);
assert.match(capabilityDialogsSource, /listSessionSkillsInSpace\(appName, selectedSpace\.id/);
assert.match(capabilityDialogsSource, /listSkillSpaces\(\)/);
assert.match(
capabilityDialogsSource,
/listSkillsInSpace\(selectedSpace\.id, selectedSpace\.region\)/,
);
assert.doesNotMatch(capabilityDialogsSource, /listSessionSkillSpaces/);
assert.doesNotMatch(capabilityDialogsSource, /listSessionSkillsInSpace/);
assert.match(skillspaceClientSource, /"\/web\/skill-spaces\?region=all"/);
assert.match(capabilityDialogsSource, /label="搜索 Skill Space"/);
assert.match(capabilityDialogsSource, /label="搜索 AgentKit 技能"/);
assert.match(capabilityDialogsSource, /skillSourceId: selectedSpace\.id/);
Expand Down

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion veadk/webui/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" type="image/svg+xml" href="/assets/volcengine-DM14a-L-.svg" />
<title>VeADK Studio</title>
<script type="module" crossorigin src="/assets/index-DYW1GYEr.js"></script>
<script type="module" crossorigin src="/assets/index-BFZ8iSb4.js"></script>
<link rel="stylesheet" crossorigin href="/assets/index-BE-8snLT.css">
</head>
<body>
Expand Down
Loading