Repository navigation
feat(pages): check useIslandForm URLs when typedRoutes is on - #733
Merged
Merged
Conversation
Island form submissions take RouteUrl, so the URL is checked against the app's routes only when routing.typedRoutes is enabled. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useIslandForm()submit URLs asRouteUrlin every adapter, including Vue and Sveltesubmit().routing.typedRoutesoff,RouteUrlstaysstring. With it on,post,put,patch,delete, andsubmitreject URLs that do not match a route. A path built at runtime can opt out withas RouteUrl.Test plan
vp test run packages/void/test/integration/route-url-builder.test.ts -t "useIslandForm|checks URL strings against routes"@void/react,@void/vue,@void/solid, and@void/svelteI'm not sure if this is considered a breaking change, but I think this should have been done when we added
typedRoutes.