Repository navigation
Conversation
Set FORCE_COLOR=1 for uncached piped tasks when the parent terminal supports colors and no explicit color controls are set. Add regression tests and a changelog entry. Refs voidzero-dev/vite-plus#2911 Co-authored-by: Codex (GPT-6) <noreply@openai.com>
Consolidate eight cases into three and remove duplicate grouped-mode checks for color controls and stdout redirection. Merge the corresponding snapshots.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcb02a8cdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Mark shell-fallback commands during planning and skip automatic FORCE_COLOR injection for uncached executions of those commands. Co-authored-by: Codex (GPT-6) <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uncached tasks lose coverage table colors when run with
vp run --log labeledor--log grouped. These modes pipe the child’s output, so tools that detect color support from stdout no longer see a terminal.It is because cached tasks already receive a
FORCE_COLORfallback, but uncached tasks bypass that environment-resolution path.Set
FORCE_COLOR=1at execution time for uncached piped tasks when the parent terminal supports colors and the task has no explicit color controls. Preserve explicitFORCE_COLOR,NO_COLOR, andNODE_DISABLE_COLORSsettings, redirected stdout, inherited stdio, and existing cached-task behavior.Add regression coverage for both log modes, explicit color controls, and stdio handling, plus a changelog entry.
Refs voidzero-dev/vite-plus#2911.
Related prior work: #378 and #379 cover color handling for cached tasks.
Validation
Related Rust suites passed before test consolidation (464 tests), and the color fixture passed afterward (5 tests). Workspace compilation, Clippy, Rust formatting, and documentation checks also passed.
The full workspace test run failed on 14 fspy static-executable tracking tests. The same 14 tests also fail on the unmodified base commit bd11071 in this environment.
AI
Codex is used for the implementation, regression tests, and validation.