Repository navigation
fix(migrate): safely merge duplicate imports - #3439
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://triagebot-fix-3430-viteplus-dev.voidzero-docs.workers.dev (commit e7224c2)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.34 MiB | 2.34 MiB | 0 B (0.00%) |
packages/core/dist |
Directory total | 4.11 MiB | 4.11 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.45 MiB | 6.45 MiB | 0 B (0.00%) |
vp (Linux x64) |
Binary | 8.35 MiB | 8.35 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 3.82 MiB | 3.82 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | Binary | 36.78 MiB | 36.79 MiB | +12.00 KiB (+0.03%) |
| NAPI (Linux x64) | gzip -9 | 14.70 MiB | 14.70 MiB | +8.54 KiB (+0.06%) |
vp (macOS ARM64) |
Binary | 5.46 MiB | 5.46 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.25 MiB | 3.25 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | Binary | 43.43 MiB | 43.43 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 18.86 MiB | 18.87 MiB | +1.25 KiB (+0.01%) |
vp (Windows x64) |
Binary | 6.19 MiB | 6.19 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 2.86 MiB | 2.86 MiB | +1 B (+0.00%) |
| NAPI (Windows x64) | Binary | 32.81 MiB | 32.82 MiB | +10.50 KiB (+0.03%) |
| NAPI (Windows x64) | gzip -9 | 13.45 MiB | 13.46 MiB | +6.33 KiB (+0.05%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.09 KiB | 7.09 KiB | +1 B (+0.01%) |
| Installer (Windows x64) | Binary | 4.68 MiB | 4.68 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.25 MiB | 2.25 MiB | +3 B (+0.00%) |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
fengmk2
changed the title
vp migrate
fengmk2
added
test: e2e
fengmk2
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp migratecan create duplicatevite-plusimports when it rewrites aviteimport. These duplicates causeimport/no-duplicateserrors.Merge adjacent imports from the same module when migration changes at least one import source. Preserve quoted export names and aliases. Keep
import typefor groups that contain only type declarations, and use inlinetypespecifiers for mixed groups.Keep intervening code, side-effect imports, and comments intact. Leave unsupported declarations, conflicting bindings, and unchanged import groups separate.
Closes #3430