Skip to content

feat(create): skip migration for templates that already use Vite+ - #3424

Merged
fengmk2 merged 2 commits into
voidzero-dev:mainfrom
liangmiQwQ:feat/create-skip-migration-for-vite-plus-templates
Nov 12, 2026
Merged

fengmk2 merged 2 commits into
voidzero-dev:mainfrom
liangmiQwQ:feat/create-skip-migration-for-vite-plus-templates

Conversation

@liangmiQwQ

Copy link
Copy Markdown
Collaborator

The current vp create always migrates the project generated by a third-party create-xxx CLI: it migrates ESLint/Prettier/tsup and rewrites the project for Vite+. When the CLI already generates a Vite+ project (for example, the upcoming Vite+ option in create-vue, vuejs/create-vue#1175), this overrides choices the template made on purpose, such as keeping ESLint or its vite-plus version.

This PR makes vp create skip these migration steps when the generated standalone project already depends on vite-plus. Follows vp migrate's behavior for projects that already use Vite+.

  • Only third-party templates are affected. Built-in and bundled templates still rely on the rewrite.
  • Packages created inside a monorepo are still rewritten so they use the workspace catalog.
  • VP_FORCE_MIGRATE=1 still runs the full migration.
  • Git, hooks, agent instructions, editor configs, the package manager pin, and install still run as before.

🤖 Generated with Claude Code

@liangmiQwQ
liangmiQwQ marked this pull request as ready for review November 10, 2026 22:11
@liangmiQwQ
liangmiQwQ requested review from fengmk2 and removed request for fengmk2 November 10, 2026 22:11
@liangmiQwQ
liangmiQwQ marked this pull request as draft November 11, 2026 13:45
@liangmiQwQ
liangmiQwQ force-pushed the feat/create-skip-migration-for-vite-plus-templates branch from edb47f0 to d7d201d Compare November 11, 2026 21:55
@liangmiQwQ
liangmiQwQ marked this pull request as ready for review November 12, 2026 13:27
@liangmiQwQ
liangmiQwQ requested a review from fengmk2 November 12, 2026 13:27
@liangmiQwQ
liangmiQwQ force-pushed the feat/create-skip-migration-for-vite-plus-templates branch from d3a12cb to 59ca1b9 Compare November 12, 2026 13:29
@fengmk2 fengmk2 self-assigned this Nov 12, 2026
@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests labels Nov 12, 2026
@fengmk2
fengmk2 merged commit 380ddea into voidzero-dev:main Nov 12, 2026
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants