Skip to content

ci: default tests to latest, add pkg.pr.new dispatch input#74

Merged
fengmk2 merged 1 commit into
mainfrom
ci/test-pkg-pr-new-dispatch
May 29, 2026
Merged

ci: default tests to latest, add pkg.pr.new dispatch input#74
fengmk2 merged 1 commit into
mainfrom
ci/test-pkg-pr-new-dispatch

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented May 29, 2026

Summary

Removes alpha-channel testing and replaces it with on-demand pkg.pr.new verification triggered manually.

  • Dropped the version: [latest, alpha] matrix from every test job. Push / PR / merge_group runs now exercise only the latest published Vite+ (the action's default). Jobs whose only matrix dimension was version lost their strategy: block; jobs with other dimensions (os, node-version, lockfile) kept theirs.
  • Added a workflow_dispatch input pr_version (a PR number or commit SHA, e.g. 1569) for verifying an unreleased Vite+ build on demand.

How pkg.pr.new testing works

pkg.pr.new builds install via VP_PR_VERSION (PR number / commit SHA), not the version input — the install script checks VP_PR_VERSION before VP_VERSION and uses it to pull the matching build from pkg.pr.new. The input feeds a workflow-level env var:

env:
  VP_PR_VERSION: ${{ github.event.inputs.pr_version }}

Since the action spreads ...process.env into the install, this flows straight through and wins even though the action sets VP_VERSION=latest. On every non-dispatch event the value is empty, which the script treats as unset → latest. So one manual dispatch verifies a candidate build across the entire matrix (install, node-version, cache, exec, sfw) with no source change to the action.

Notes

  • The build job is pinned to latest (VP_PR_VERSION: "") so a pre-release bundler can't shift dist/ output and fail the "dist is up to date" diff for unrelated reasons.
  • The sfw jobs now ride the dispatched version too; their stale "covers the alpha channel" comments were updated.

🤖 Generated with Claude Code

Remove the `version: [latest, alpha]` matrix from every test job so
push/PR/merge_group runs only exercise the latest published Vite+.

Add a `workflow_dispatch` input (`pr_version`) for verifying an
unreleased Vite+ build on demand. It feeds a workflow-level
`VP_PR_VERSION` env var, which the install script checks before
`VP_VERSION` and uses to pull the matching build from pkg.pr.new — so a
single manual run verifies a candidate across the whole matrix. The
value is empty on every other event, which the install script treats as
unset and falls back to latest.

The build job is pinned to latest (`VP_PR_VERSION: ""`) so a pre-release
bundler can't shift dist/ output and fail the "dist is up to date" diff.
Copilot AI review requested due to automatic review settings May 29, 2026 07:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CI to test the default latest Vite+ release on normal events while allowing manual workflow dispatches to verify an unreleased pkg.pr.new Vite+ build via VP_PR_VERSION.

Changes:

  • Adds a workflow_dispatch pr_version input and workflow-level VP_PR_VERSION environment variable.
  • Removes the latest/alpha version matrix from test jobs.
  • Pins the build job to latest by clearing VP_PR_VERSION, and updates related sfw comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengmk2 fengmk2 merged commit 8b7d810 into main May 29, 2026
34 checks passed
@fengmk2 fengmk2 deleted the ci/test-pkg-pr-new-dispatch branch May 29, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants