Repository navigation
Conversation
Commit dd8d3f8 introduces a modification of config.sh at the end of the configure phase. This leads to config.h, which depends on config.sh, being rebuilt during the build phase. config.h is required for some targets that do not explicitly depend on config.h, leading to a race condition in which these other targets may be attempted to be built with a half-generated config.h during multi-job builds. Replace the previous sig_count fix with one that does not modify files at the end of the configure phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit dd8d3f8 introduces a modification of config.sh at the end of the configure phase. This leads to config.h, which depends on config.sh, being rebuilt during the build phase. config.h is required for some targets that do not explicitly depend on config.h, leading to a race condition in which these other targets may be attempted to be built with a partially-generated config.h during multi-job builds (when
XBPS_MAKEJOBSis greater than 1).Replace the previous sig_count fix with one that does not modify files at the end of the configure phase.
I was not sure whether or not to include a revbump, as this change should not alter the contents of the package in the cases in which the build completes successfully.
Thank you for your time in looking at this.
Testing the changes
Local build testing