Skip to content

perl: fix race condition in multi-job build. - #63669

Open
Gorggg wants to merge 1 commit into
void-linux:masterfrom
Gorggg:perl_build_race_condition
Open

Gorggg wants to merge 1 commit into
void-linux:masterfrom
Gorggg:perl_build_race_condition

Conversation

@Gorggg

@Gorggg Gorggg commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Commit dd8d3f8 introduces a modification of config.sh at the end of the configure phase. This leads to config.h, which depends on config.sh, being rebuilt during the build phase. config.h is required for some targets that do not explicitly depend on config.h, leading to a race condition in which these other targets may be attempted to be built with a partially-generated config.h during multi-job builds (when XBPS_MAKEJOBS is greater than 1).

Replace the previous sig_count fix with one that does not modify files at the end of the configure phase.

I was not sure whether or not to include a revbump, as this change should not alter the contents of the package in the cases in which the build completes successfully.

Thank you for your time in looking at this.

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-musl)
  • I built this PR locally for these architectures:
    • armv7l (cross-built)

Commit dd8d3f8 introduces a
modification of config.sh at the end of the configure phase. This leads
to config.h, which depends on config.sh, being rebuilt during the build
phase. config.h is required for some targets that do not explicitly
depend on config.h, leading to a race condition in which these other
targets may be attempted to be built with a half-generated config.h
during multi-job builds.

Replace the previous sig_count fix with one that does not modify files
at the end of the configure phase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant