libreoffice: fix parallel build [ci skip] - #62610
Open
tylerRosso wants to merge 1 commit into
Open
tylerRosso wants to merge 1 commit into
tylerRosso wants to merge 1 commit into
Conversation
c7851c1 replaced "make ${makejobs}" with "make PARALLELISM=$MAKEJOBS", but xbps-src defines no MAKEJOBS variable (only XBPS_MAKEJOBS and makejobs). The resulting empty PARALLELISM= on the make command line overrides the --with-parallelism value written by configure, and LibreOffice's Makefile then passes no -j to gbuild, so the whole build ran with a single job. Use XBPS_MAKEJOBS instead. No revbump: the produced packages are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Since c7851c1 do_build passes PARALLELISM=$MAKEJOBS to make. xbps-src has no such variable so the value is empty and gbuild runs with a single job.
I've noticed it because libreoffice was building on one core despite having XBPS_MAKEJOBS=14. With this change all 14 cores are used again.
No revbump, the packages themselves don't change. CI skipped since libreoffice takes far too long for it.
I used Claude to help find the cause.