You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry for the mess and noise in the commit history earlier! I've cleaned it all up into a single commit containing only fcitx5-lotus. Thank you for your patience!
Package description:
fcitx5-lotus is a Vietnamese input method engine for Fcitx5, focusing on a non-preedit (direct typing) experience.
Technical notes:
-The package creates a '_uinput_proxy' system user. This is because the engine uses a background daemon to access '/dev/uinput' for simulating keyboard events (to achieve the 'non-preedit' typing). This follows the principle of least privilege, running the daemon under a dedicated user instead of root.
-The flag '-DINSTALL_RUNIT=ON' is used to install the runit service scripts required for Void Linux.
-'acl' is included in depends because the post-install script uses 'setfacl' to grant the '_uinput_proxy' user access to '/dev/uinput'.
-'python3' is listed in hostmakedepends because the build system uses it at configure time (find_package(Python3)) and at install time (byte-compiling the settings GUI Python files).
-Upstream uses the generic username 'uinput_proxy' in its runit service and udev rules. Since Void Linux convention requires system users to have an underscore prefix, 'post_patch()' is used to sed-replace 'uinput_proxy' with '_uinput_proxy' in 'misc/fcitx5-lotus.runit' and 'misc/99-lotus.rules' before build (The 'post_patch()' sed-replacement is a temporary workaround.).
-Systemd service file and sysusers.d config are removed in 'post_install()' as they are not needed on Void.
-The settings GUI is split into a subpackage 'fcitx5-lotus-settings' to avoid pulling Python/Qt dependencies into the main package, since headless or terminal-only users may not need the GUI.
-bamboo-core is fetched as a separate distfile (Git submodule) and placed into the source tree via 'post_extract()'.
-bamboo-core is written in Golang, which is why 'go' is listed in hostmakedepends. The build process compiles bamboo-core from source before building fcitx5-lotus itself.
Notes from the Maintainer:
-If this package is merged, I plan to submit a request to upstream to make the proxy username configurable (e.g. via a CMake variable like 'UINPUT_PROXY_USER'), so that the 'post_patch()' workaround will no longer be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Built and tested on glibc x86_64.