Repository navigation
feat(plugin-page): the page is a picture, like the upstream plugins' - #150
Merged
Merged
Conversation
The upstream page this was compared against (`自定义插件索引`) renders exactly one
line of Markdown on its plugin page:
The title, the version and the one-sentence description sit in the page HEADER —
from `locale` `meta.title` / `meta.description` — so a detail document that
repeats them is saying it twice.
So `docs/detail.md` and `docs/detail.zh-CN.md` are now one image line each, and
the image is a UI preview rather than a brand banner: on the left the settings
card (the three groups, the switches), on the right the Go meter that sits above
the composer (three windows, the monthly allowance, the refresh). Two pictures,
one per language, generated from one layout so they cannot drift.
`test/plugin-detail.test.ts` now asserts the page is **the picture and nothing
else** — one non-empty line, an image, its file present and shipped — instead of
linking onward, which was a rule about long pages rather than about this one.
The language-pair gate gained the axis these pages actually have: the two
languages must SHOW the same number of pictures, and each referenced file must
exist. Its other axes lost their minimums — a page with no headings and no table
is not a pairing failure, and a floor tuned to a 461-line README was measuring
the wrong thing.
The brand banner stays, in the READMEs only.
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream page this is modelled on (
自定义插件索引) renders exactly one line of Markdown on its plugin page:The title, the version and the one-sentence description are in the page header — from
localemeta.title/meta.description— so a detail document that repeats them says it twice.The page is now a picture
docs/detail.md/docs/detail.zh-CN.mdare one image line each, and the image is a UI preview, not a brand banner:Two pictures, one per language, generated from one layout so they cannot drift.
What the tests now hold
test/plugin-detail.test.tsasserts the page is the picture and nothing else — one non-empty line, an image, its file present and shipped. It used to require links onward, which was a rule about long pages rather than about this one.The language-pair gate gained the axis these pages actually have: the two languages must show the same number of pictures, and each referenced file must exist. Its other axes lost their minimums — a page with no headings and no table is not a pairing failure, and a floor tuned to a 461-line README was measuring the wrong thing.
Verified through the host's own resolver
The brand banner stays — in the READMEs only.
vp checkscripts/check.ts