Repository navigation
Conversation
The test install now runs the host users run. - pi is pinned to 1.1.0, the version the harness's own lockfile pins, with the harness's patch applied verbatim (patches/, hash recorded by pnpm). A pnpm override holds every copy in the tree to it, not just the direct devDependency. - The @deepseek-ai packages move from 0.2.1-alpha.5 to 0.2.1-rc.2, the version a registry install of the published dsh resolves (cordis 4.0.5, loader 1.0.6, schemastery 3.18.5). The boot-tier packages the real-host harness needs next (dsh-llm, dsh-app-boot, dsh-config-editor, dsh-settings, cordis-plugin-loader) are added as devDependencies. - test/support/host-versions.ts names those versions once. test/host-versions.test.ts checks that the pi the plugin loads at runtime is 1.1.0 and the same copy the tests import, that the patch is applied, and that the installed cluster matches. - mount-protocols now checks that every catalog SDK maps to a protocol pi's exported api modules implement, and records as a characterization row that pi 1.1.0's opencode-go provider has no Google API. No src/ behaviour changes: the rc.2 builds of llm-pi-ai, cordis and schemastery are code-identical to alpha.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Owner
Author
|
No fix exists yet. The shim needs Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase P-T1a of
docs/improvement-plan.md. It is stacked on #108 (P2), which sits on #107, #106 and #105.After this PR, the test install runs the host users run (D14, D22). It is a pinning phase, so no
src/behaviour changes.What is pinned
@earendil-works/pi-aioverridesentry holds every copy in the tree to it, including the onedsh-llm-pi-ai's^1.1.0would otherwise float. The patch is copied verbatim intopatches/, and its hash matches the one the harness lockfile records.@deepseek-ai/*dshresolves. The rc.2 builds of llm-pi-ai, cordis and schemastery have the same code as alpha.5; only theirpackage.jsonranges differ.dsh-llm,dsh-app-boot,dsh-config-editor,dsh-settings,cordis-plugin-loaderminimumReleaseAgeExcludeis now empty. Every pinned version is older than pnpm's 24-hour release-age window, so nothing needs that window lifted.Tests
test/support/host-versions.tsnames the pinned versions once.test/host-versions.test.tschecks four things:loadHostPi) is 1.1.0, and it is the same module instance the tests import.dist, and the lines the patch removes are absent.@deepseek-aicluster matches the pinned versions, within the plugin's own declared ranges.test/mount-protocols.test.tsis rewritten. It now checks that every catalog SDK maps to a protocol that pi's exportedapi/*modules implement. It keeps a characterization row: pi 1.1.0'sopencode-goprovider has no Google API (F10). That gap is what the plugin's provider fills in P-R1.test/harness-channel.test.tsreads the channel fromHOST_VERSIONSinstead of an alpha-channel regex.test/no-local-paths.test.tsnow also scanspatches/andpnpm-workspace.yaml.Review
The change went through three review lenses (correctness and host contracts, tests, repository rules), and two independent skeptics checked each finding. Over three rounds, every upheld finding was fixed: 3 medium and 21 low.
Verification
All run locally:
pnpm install --frozen-lockfilepnpm run checktest:mockscripts/check.tstest:mockThe diff and the patch file contain no local paths.
Note on CI: the
catalog freshnesscheck will fail here for the reason described on #108. The vendor added a Go model (kimi-k3.1-pro), and this PR doesn't touch the catalog. The nightly refresh fixes it.Generated by Claude Code