Repository navigation
feat(json): add reusable SerializeOptions for dumps and dump_file - #1
Open
ayushactiveat wants to merge 1 commit into
Open
ayushactiveat wants to merge 1 commit into
ayushactiveat wants to merge 1 commit into
Conversation
Author
|
@GaspardKirira let me know if any changes are needed |
Member
|
Okay, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes vixcpp/vix#543.
adds SerializeOptions { pretty, indent, ensure_ascii } and overloads
of dumps() and dump_file() (fs::path, const char*, std::string).
previous positional overloads are unchanged, ie, indent < 0 =
compact.
indent < 0 throws std::invalid_argument.
new test file json_dumps_options_test.cpp covers compact/pretty/
custom indent / ensure_ascii / invalid options / dump_file-with-options,
plus compat checks that positional overloads still work.
tested locally