Repository navigation
Check metamodels and reactions before the Maven build - #49
Merged
Merged
Conversation
Most mistakes are now rejected in milliseconds, before Maven runs, with the location in the upload and a suggestion: - Reactions: metamodel aliases, alias::Class (incl. subpackages and qualified names), trigger features (attribute or reference, multiplicity, element type), and abstract classes in create blocks. The rules follow the grammar, scope providers, and validator of the Reactions language 4.0.0; anything uncertain is left to the compiler. - Metamodels: names that differ only in case (classes, inherited features, enum literals), Java reserved words as class names, and classes named like the generated package/factory interfaces, each confirmed to break the generated code. EMF validation messages name the element instead of dumping objects and carry a hint. - Compiler messages of the Reactions build get hints from a catalog. The README describes the checks and their dependency on the Reactions language rules. Refs #44 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
- Use possessive quantifiers in the checker's patterns: backtracking could not find other matches anyway, and possessive matching cannot overflow the stack on long input. - Match triggers in parts instead of one large pattern, and split the trigger and metaclass checks into smaller methods. - Use \w, constants for repeated literals, no nested ternaries. - Tests: assert that valid inputs are accepted, and keep only the failing call inside assertThrows. The checker's results are unchanged: the same findings and mutation detection over 337 reactions files of real projects. Refs #44 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uiysg
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most mistakes are now rejected in milliseconds, before Maven runs, with the location in the upload and a suggestion:
The README describes the checks and their dependency on the Reactions language rules.
Refs #44