Skip to content

Compile NeoJoin views into the generated VSUM #55

Closed

Description

@arlange

Context

NeoJoinViewDefinitionProcessor is a stub. It copies the files to views/src/main/neojoin (not a
Maven module) and logs a warning. vsumMain.ftl:127-133 only registers identity view types.

Tasks

  • Replace the stub: put the .nj files on the classpath of the generated project, e.g. in
    vsum/src/main/resources/views/, or turn views into a real module in rootPom.ftl
  • vsumPom.ftl:
    • add the NeoJoin integration dependency (NJ-2) only when views are present
    • put the version in a property
  • vsumMain.ftl: register one NeoJoinViewTypeFactory.fromClasspath(...) per view in
    createViewTypes(), next to the identity view types
  • Map NeoJoin errors from the Maven build to Source.VIEWS problems
  • Docker image:
    • pre-load the NeoJoin dependencies in Dockerfile and VsumBuildWarmup (offline build)
    • add a .nj sample to resources/vsum-sample/
  • Update VsumProjectBuildServiceTest:
    • replace the "view stub" content with a real query
    • assert that the generated project builds and registers the view type
  • Update README (Features, viewFiles), WORKPLAN and the @Parameter descriptions in
    VsumController

Acceptance criteria

  • A VSUM built with a .nj file starts.
  • The view type appears in Vitruv-Server under GET /vsum/view/types, and a view can be fetched
    through /vsum/view.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions