Skip to content

Check NeoJoin view definitions before the build #54

Closed

Description

@arlange

Context

VsumBuildRequest.java:63 reads viewFiles with read(viewFiles, "view definition", null), so any
file extension is accepted. The only check is for duplicate names. Source.VIEWS exists in
BuildProblem/ProblemReport, but nothing produces it. Reactions are already checked before Maven
runs (ReactionsChecker); views should get the same.

Tasks

  • Add the constant .nj and accept only that extension (analogous to .reactions / .ocl)
  • NeoJoinChecker:
    • parse every file with NeoJoin (NeoJoinStandaloneSetup), using the uploaded and processed
      metamodels as the meta-model path
    • report syntax errors, unresolved import nsURIs and Xbase type errors as
      BuildProblem{source: VIEWS, file, line, column, message}
  • Report duplicate export names / view-type nsURIs across files
  • Run the checker through the same code path in /build, /jar and /validate (Validate projects without building them #52)
  • Tests:
    • a valid query
    • a syntax error
    • an unknown import
    • a wrong file extension

Acceptance criteria

  • A broken .nj file fails the build before Maven runs, with a problem that points to the file and
    line.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions