Skip to content

feat(oxc): lint results inspecteor#432

Merged
antfu merged 26 commits into
mainfrom
chore/clean-code
Jul 21, 2026
Merged

feat(oxc): lint results inspecteor#432
antfu merged 26 commits into
mainfrom
chore/clean-code

Conversation

@yuyinws

@yuyinws yuyinws commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Rework the Oxc Devtools around persisted lint results, nested configuration discovery, standalone Devframe CLI support.
oxc-devtools-play.mp4

Non-Oxc changes

  • packages/core/playground: updates the playground so oxc-devtools can be exercised and visually verified there.
  • packages/rolldown/src/app and packages/ui/src/utils/date-groups.ts: move the date-grouping helper into the shared UI package so Rolldown and Oxc can reuse it.
  • packages/ui/src/utils/icon.ts: reorder package-ID matching to prevent package paths from being classified by an earlier, broader rule.

Closes #433

@yuyinws yuyinws changed the title chore/clean code chore: clean code Jul 16, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jul 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@432

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@432

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@432

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@432

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@432

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@432

commit: fbd8e24

@yuyinws
yuyinws marked this pull request as ready for review July 16, 2026 09:01
@yuyinws yuyinws changed the title chore: clean code refactor(oxc): remove lint log cli Jul 16, 2026
Comment thread packages/oxc/package.json
"@clack/prompts": "catalog:inlined",
"@vitejs/devtools-kit": "workspace:*",
"ansis": "catalog:deps",
"cac": "catalog:deps",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually ok with keeping gunshi for a bit of diversity

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cac is more lightweight than gunshi. Given that the current CLI is relatively simple, I think it's a better fit for now. We can consider switching to gunshi if the CLI grows more complex in the future.

@antfu

antfu commented Jul 17, 2026

Copy link
Copy Markdown
Member
CleanShot 2026-07-17 at 11 39 24@2x I am seeing this - should we have a button to run/rerun the lint? Do we still need the concept of sessions or it's always the live result?

@yuyinws

yuyinws commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

The complete implementation of the lint inspector will be submitted in a separate PR.

The current proposal is:

  1. Trigger linting via a button.
  2. Persist lint results to local files to enable historical snapshots.
  3. Allow users to delete lint history directly from the UI.

@antfu

antfu commented Jul 17, 2026

Copy link
Copy Markdown
Member

Would you like to directly implement it in this PR? Right now this PR only remove the cli which makes this devtools' feature incomplete

@yuyinws
yuyinws marked this pull request as draft July 17, 2026 03:33
@yuyinws yuyinws changed the title refactor(oxc): remove lint log cli feat(oxc): lint results inspecteor Jul 17, 2026
@yuyinws
yuyinws marked this pull request as ready for review July 19, 2026 01:32
@yuyinws
yuyinws requested a review from antfu July 19, 2026 01:32
@antfu

antfu commented Jul 21, 2026

Copy link
Copy Markdown
Member

The new changes look awesome! Great work!

A bit nitpicking for the ui, for the detailed page, do you think it's worth being a dialog instead of a page (like before)? As this is where users would spend most of the time on, I wonder if it would be better to be like a page?

# Conflicts:
#	packages/oxc/src/node/rpc/index.ts
#	pnpm-lock.yaml
@antfu
antfu merged commit 2a7a57e into main Jul 21, 2026
10 checks passed
@antfu
antfu deleted the chore/clean-code branch July 21, 2026 06:29
@yuyinws

yuyinws commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Yeah, A separate page would be better. Will implement it in the follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(oxc): lint results inspector

3 participants