Upgrade clap 2.x to 4.x - #118
Open
JacobHayes wants to merge 1 commit into
Open
Conversation
clap 2.33.3 depends on atty, which is unmaintained and has a
soundness issue. clap 4.x removes this dependency.
Migrates the CLI to the clap 4 API:
- App -> Command
- Arg::with_name -> Arg::new
- .short("x") -> .short('x')
- .takes_value(true) removed (now the default)
- .value_of() -> .get_one::<String>()
tyt2y3
force-pushed
the
master
branch
7 times, most recently
from
March 23, 2026 15:30
21c8047 to
fd9cdb0
Compare
tyt2y3
force-pushed
the
master
branch
4 times, most recently
from
August 1, 2026 22:45
3aef551 to
7d754e1
Compare
tyt2y3
force-pushed
the
master
branch
14 times, most recently
from
August 8, 2026 21:25
f0b04ae to
845f6a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clapfrom 2.33.3 to 4.x to address vulnerabilities in transitive dependencies (e.g.atty)App→Command,Arg::with_name→Arg::new,.value_of()→.get_one::<String>(), etc.)Test plan
cargo checkpassescargo run -- --input <img> --output <out.svg>produces equivalent output