Repository navigation
feat: enhance gutter and split pane functionality with visibility and sizing improvements - #2
Merged
Merged
Conversation
… sizing improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes split-pane sizing to use the available content area after borders, padding, and gutters. Oversized initial allocations shrink to fit, and pane proportions survive collapse to zero space and recovery, including when panes are added while collapsed. Destroyed panes and cyclic insertions are rejected before changing layout state.
Gutters now update their size and appearance in place instead of being recreated. Appearance updates preserve active drags. The public gutter visibility property changes from showHairline to gutterVisibility, and gutter options reuse the shared appearance interface.
Pane targeting filters hidden and destroyed renderables. Drag-drop preserves existing root mouse handlers, including handlers assigned after controller creation, and cancels drops when the dragged pane becomes hidden or detached. Shared visibility, hit-testing, sizing, and detachment logic reduce duplication.