Issue 52 record update payload - VDNS-428 - #92
Merged
JoshSEdwards merged 8 commits intoAug 18, 2026
Merged
Conversation
… bug fix guess to record.py
…time parsing isues
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage ? 93.89%
=========================================
Files ? 9
Lines ? 1147
Branches ? 0
=========================================
Hits ? 1077
Misses ? 70
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JoshSEdwards
added a commit
that referenced
this pull request
Aug 18, 2026
* adding in unit test to reproduce and fix datetime error /bug. updated bug fix guess to record.py * removing unecessary fields in update_record_set payload to avoid datetime parsing isues * fixing formatting issues * fixing formatting issues * fixing formatting issues * fixing formatting issues * fixing formatting issues * fixing formatting issues Co-authored-by: mschaefer28 <315495672+mschaefer28@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Issues with the created/updated datetime fields not being accepted in the update_record_set call.
Approach: Adjusting the update_record_set function to call a helper which creates a new payload leaving out any unnecessary fields that the API does not require (created, fqdn, updated, status etc). This way we will not receive any datetime parsing errors since the fields are not included. Only did this at the update record set level so it does not affect other API calls.
Validation: Created unit test that passes in bad fields to the payload and double checks that the field doesnt exist in the body when checked. Will assert an error if it does.
Closes #52