Repository navigation
GHA: and harden existing workflows - #583
Open
guidoiaquinti wants to merge 1 commit into
Open
guidoiaquinti wants to merge 1 commit into
guidoiaquinti wants to merge 1 commit into
Conversation
Owner
|
I'll take a closer look at this one in the coming days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new GitHub Workflows CI workflow that lints and audits the workflows in this repo, and fixes everything it reported so it passes from the first run.
v1.7.12): downloads the release, checks it against the published checksum, then runs it. Shell scripts inrun:steps are also checked with shellcheck.v1.30.1): runs throughuvxaszizmor --persona=auditor --collect=workflows .Both jobs check out without keeping credentials, use read-only permissions, and pin their actions to commit SHAs.
zizmorreported 45 findings in the current workflows. All of them are fixed or explicitly ignored.Notes for maintainers
Unit Tests (Python 3.10)instead ofbuild (3.10). If branch protection requires the old names, those required checks need updating.pypienvironment. GitHub creates it automatically on the first release run, and the existing repository secrets (PYPI_USERNAME,PYPI_PASSWORD) still work in it. You can add protection rules to it, such as required reviewers, to guard releases.github-actionsecosystem would keep them current.