fix(apps): an app review card no longer outlives the review (v0.447.2) - #832
Merged
Merged
Conversation
The Apps console acts on the APP, never on the card, so nothing ever closed an `app.proposed` card: an app published weeks ago still read "awaiting review" in Needs you, with no button to clear it. Live: five open cards on one tenant, the oldest two months old — the same bug the skills lane fixed in v0.404.1. - publishing an app closes its card (publishing IS the card's ask), deleting one closes it too; - a boot sweep heals cards the old routes left behind, re-deriving each from the apps store: published reads as approved, gone as rejected; - a card whose app is still sitting unpublished is left open — that one is genuinely pending. Unpublishing closes nothing either: an agent's edit to a live app unpublishes it precisely to ask for a re-review; - every review card gained a Dismiss button — the escape hatch for one whose subject was handled outside the console. Per-member hide, exactly what "dismiss all" already did in bulk. Pinned by scripts/app-card-close-test.cjs (in the governance gate). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
app.proposedcard sat in Needs you forever. The Apps console acts on the app, never on the card, so publishing, unpublishing or deleting the app left the card open — and review cards had no Dismiss button. Live: five open cards on one tenant, the oldest two months old. Same bug the skills lane fixed in v0.404.1, same shape of fix.approved) — publishing is literally what the card asks for. Delete closes it (rejected) — it can never be acted on again.sweepStaleSkillProposals.message_state); the proposal stays open on its own page for everyone else.dismiss allalready did exactly this in bulk.Pinned by
scripts/app-card-close-test.cjs, added tonpm run test:governance: publish/delete close, unpublish doesn't, and the sweep heals stale cards while leaving a pending one open.npm run typecheck,cd web && npm run build, and the full governance gate all pass.🤖 Generated with Claude Code