Skip to content

ARC-3762 change default content block text input#349

Merged
bertyhell merged 3 commits into
mainfrom
feature/ARC-3762-default-text-input
Jun 30, 2026
Merged

ARC-3762 change default content block text input#349
bertyhell merged 3 commits into
mainfrom
feature/ARC-3762-default-text-input

Conversation

@bertyhell

@bertyhell bertyhell commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

https://meemoo.atlassian.net/browse/ARC-3762

make default content block text input editor type text input instead of rich text editor
less duplicate code, easier to find rich text editor uses in admin-core
also changed order of TEXT_FIELD() params, so custom validator message is last, so it can be omitted if undefined

@reunefe reunefe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je hebt wel op heel wat plekken die validator op undefined gezet. Is het niet beter naast TEXT_FIELD ook een sensible default te voorzien zoals TEXT_FIELD_REQUIRED? Dat is minder vervuiling elders.

Gewoon een voorstel

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@bertyhell

Copy link
Copy Markdown
Contributor Author

Je hebt wel op heel wat plekken die validator op undefined gezet. Is het niet beter naast TEXT_FIELD ook een sensible default te voorzien zoals TEXT_FIELD_REQUIRED? Dat is minder vervuiling elders.

Gewoon een voorstel

hmm ja, heb ik overwogen
maar ik denk dat alle text velden dezelfde helper laten gebruiken waardevoller is
dan kan je die makkelijk overal terugvinden

want dat was nu net het issue, dat rich text editor type de default was en dat je dus niet kon zien aan de code waar die gebruikt werden. nu wel, nu kan je zoeken op TEXT_FIELD() met editorType: Richtext

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@bertyhell bertyhell merged commit 892dffd into main Jun 30, 2026
1 check passed
@bertyhell bertyhell deleted the feature/ARC-3762-default-text-input branch June 30, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants