fix: drop word spacing in Japanese ("5 分 前" -> "5分前") - #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Japanese does not put spaces between words, but the
Japaneselanguage inherited the default" "forbetween_value_and_word/between_chunks/override_space_near_ago, so durations rendered as "5 分 前" and "1 週間 前" instead of "5分前" / "1週間前".The
Japaneseimpl dates back to #13 (2018), before those spacing hooks existed; when they were added (#36) with a" "default, Japanese was never updated to opt out. This overrides the three hooks to"", the same approach Korean already carries forbetween_value_and_word(#38).Adds a test (Japanese had none) covering both the direct and the
BoxedLanguagepaths, mirroring the Korean test.