fix(windows): honor dirty regions when presenting software canvas frames - #243
Open
oshtz wants to merge 1 commit into
Open
fix(windows): honor dirty regions when presenting software canvas frames#243oshtz wants to merge 1 commit into
oshtz wants to merge 1 commit into
Conversation
|
@oshtz is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Frame-budget impact
Before this change, every update converted and invalidated the entire surface. After the initial full frame, work scales with the damaged rectangle: on the issue's 718x759 reproduction, a representative 718x64 repaint band processes 45,952 pixels instead of 544,962, a 91.6% reduction in conversion work for that update.
Testing
zig build test-canvaszig build test-desktop-platform: 182 passed, 1 skipped, 6 existing failures; cleanmainreports 181 passed, 1 skipped, the same 6 failuresscripts/gate.sh fast origin/main(the broad Windows checkout remains red only in failures reproduced on cleanmainand local example dependency/symlink setup)Fixes #236