fix(eve): stamp approval as a direct defineTool property - #112
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approvalas a direct inlinedefineToolproperty so eve 0.44+ can stampapprovalRequest. After fix(eve): stamp toModelOutput as a direct defineTool property #110, spreadingresolveEveApproval(...)still discarded the whole GitHub toolset on write tools.execute,toModelOutput, orapprovalare spread or not inline ondefineTool.turbo testinto the quality job.Test plan
pnpm test(SDK vitest +durable-define-toolAST guard)createPullRequest) no longer logscallback "approvalRequest" does not have a durable descriptoralways()policy