Skip to content

fix(eve): stamp approval as a direct defineTool property - #112

Merged
HugoRCD merged 1 commit into
mainfrom
fix/eve-durable-tomodeloutput
Aug 28, 2026
Merged

fix(eve): stamp approval as a direct defineTool property#112
HugoRCD merged 1 commit into
mainfrom
fix/eve-durable-tomodeloutput

Conversation

@HugoRCD

@HugoRCD HugoRCD commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Register approval as a direct inline defineTool property so eve 0.44+ can stamp approvalRequest. After fix(eve): stamp toModelOutput as a direct defineTool property #110, spreading resolveEveApproval(...) still discarded the whole GitHub toolset on write tools.
  • Add an AST CI guard that fails if execute, toModelOutput, or approval are spread or not inline on defineTool.
  • Wire turbo test into the quality job.

Test plan

  • pnpm test (SDK vitest + durable-define-tool AST guard)
  • Consumer agent on eve 0.46: a write tool (createPullRequest) no longer logs callback "approvalRequest" does not have a durable descriptor
  • Read tools still resolve; write tools still pause for approval under the default always() policy

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
github-tools-docs Ready Ready Preview, v0 Aug 28, 2026 4:28pm
github-tools-test-agent Ready Ready Preview, v0 Aug 28, 2026 4:28pm

@github-actions github-actions Bot added the bug Something isn't working label Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@HugoRCD
HugoRCD merged commit 790f68d into main Aug 28, 2026
15 checks passed
@HugoRCD
HugoRCD deleted the fix/eve-durable-tomodeloutput branch August 28, 2026 16:34
@github-actions github-actions Bot mentioned this pull request Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant