feat(errors): 401 pós-upgrade mostra "plano sendo ativado" (não "faça login") - #13
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Mafralpm
force-pushed
the
feat/plan-provisioning-message
branch
from
July 30, 2026 00:08
d2dbb0d to
f2adc80
Compare
… login") Logo apos um upgrade de plano, o entitlement leva 1 a 2 min pra propagar e o router responde 401 "Not Enough Credits". O handler generico de 401/403 mandava o usuario fazer /login, mensagem errada (login nao resolve) e no pior momento (recem pagou). Aconteceu com um cliente MAX e virou ticket. Adiciona um caso antes do handler generico que detecta o 401 de billing/provisionamento e mostra "seu plano esta sendo ativado, tente em instantes" (tipo billing_error, que nao dispara o fluxo de login). Espelha o padrao ja existente do "Credit balance is too low". 401 de autenticacao real segue indo pro /login (sem regressao). Testes: - errors.planProvisioning.test.ts (novo): (1) 401 "Not Enough Credits" produz a mensagem de ativacao e NAO contem "/login"; (2) 401 de auth real continua contendo "/login". - Regressao errors.openaiCompatibility.test.ts: 5 pass. - bun run build ok; tsc 0 erros novos. Nota: match pela mensagem retornada; ideal e o router expor um codigo estavel (registrado no comentario do codigo). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ImPedro29
force-pushed
the
feat/plan-provisioning-message
branch
from
July 30, 2026 23:37
f2adc80 to
962848e
Compare
ImPedro29
approved these changes
Jul 30, 2026
ImPedro29
left a comment
ImPedro29
left a comment
There was a problem hiding this comment.
Aprovado após restringir a classificação ao router Verboo. Provisioning estruturado, legado neutro, crédito esgotado e autenticação real estão separados e cobertos. Validação: 26 testes focados, smoke/build e todos os checks do PR verdes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
Um 401 de provisioning pós-upgrade não deve mandar o usuário para login, mas mensagens genéricas de crédito também não podem ser tratadas como prova de que houve upgrade.
Implementação
Contrato recomendado do backend
O router deve enviar error.code igual a plan_provisioning. Respostas legadas Not Enough Credits continuam suportadas de forma conservadora.
Validação