fix(isFloat): fall back to '.' separator for an unknown locale - #2878
Open
yfwmaniish wants to merge 1 commit into
Open
fix(isFloat): fall back to '.' separator for an unknown locale#2878yfwmaniish wants to merge 1 commit into
yfwmaniish wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2878 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2600 +1
Branches 658 658
=========================================
+ Hits 2599 2600 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2862.
Bug
isFloatinterpolates the locale separator straight into a newRegExp:When
options.localeis not a key ofdecimal,decimal[options.locale]isundefined, which stringifies into the pattern as the literal textundefined. The preceding\yields\undefined, and since\uisn't followed by four hex digits it degrades to a literalu, so the "decimal separator" becomes the 8-character stringundefined. There's no error and no fallback:Fix
Fall back to
.when the locale is unknown:Known locales are unaffected (their separator is always
.or,, both truthy), and the no-locale path already resolved to..Tests
Added an unknown-locale block asserting ordinary decimals validate and the
undefined-separator strings no longer pass. Verified known-locale behavior (en-US., de-DE,) is unchanged.