Skip to content

Hex+aes#71

Merged
vadv merged 5 commits into
masterfrom
hex+aes
Jun 26, 2025
Merged

Hex+aes#71
vadv merged 5 commits into
masterfrom
hex+aes

Conversation

@scr-oath

Copy link
Copy Markdown
Collaborator

No description provided.

@scr-oath scr-oath mentioned this pull request Jun 24, 2025

@dborovcanin dborovcanin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more details to the README, so these two approaches are better documented. Overall, this looks good to me.

Comment thread crypto/test/test_api.lua Outdated
@scr-oath

scr-oath commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator Author

Please add some more details to the README, so these two approaches are better documented. Overall, this looks good to me.

Nice - I actually found some bugs in the README - since you're calling ToString and not doing a switch on the type - passing 1 would not become the GCM constant, it would fail to lookup in the mapping. I changed the example to agree. We could also fix that by adding 1,2,3 as mappings… hmm… on second thought - passing numbers isn't very meaningful… I would rather leave it as is and the documentation agrees with what string values can be sent.

I added some "constants" (members of the crypto) that can be used rather than bare strings or numbers.

@scr-oath scr-oath marked this pull request as ready for review June 25, 2025 23:47
@scr-oath scr-oath requested a review from vadv June 25, 2025 23:47
@scr-oath scr-oath requested a review from dborovcanin June 25, 2025 23:47
@dborovcanin

Copy link
Copy Markdown
Contributor

@vadv Can you, please, check on this one and merge (if it's OK) when you find time and create a release? We are using it in the rules engine here: https://github.com/absmach/magistrala/tree/main/re, and it would be nice to have and use the latest stable version.

@vadv vadv merged commit 7c75a2e into master Jun 26, 2025
6 checks passed
@vadv

vadv commented Jun 26, 2025

Copy link
Copy Markdown
Owner

Thanks guys!
@scr-oath @dborovcanin 🙇

tag: v0.7.0

@vadv vadv deleted the hex+aes branch June 26, 2025 19:01
@dborovcanin

Copy link
Copy Markdown
Contributor

Thanks a lot, @vadv ! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants