fix(codeapi-chart): avoid service worker surge rollout#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Fixes
This PR changes the CodeAPI service-worker Deployment rollout strategy so updates do not require a temporary second service-worker pod.
Staging exposed this with the default Deployment rolling update behavior: one replica rounded to
maxUnavailable: 0andmaxSurge: 1, so AKS tried to schedule an extra worker with 2560Mi memory and 500m CPU requests. The eligible pools had no room for the surge pod, leaving the rollout stuck with the new pod pending and the old pod still running.The service worker is an async queue consumer, so replacing it in place is a better default than reserving extra surge capacity for every update.
Branch Coverage
main3a607d5helm/codeapi/templates/worker-sandbox-deployment.yamlVerification
Current head:
helm lint helm/codeapi -f /private/tmp/df-cloud-codeapi-stg-rollout/helm-charts/codeapi/stg/values.yaml-> passedhelm template codeapi helm/codeapi -n codeapi -f /private/tmp/df-cloud-codeapi-stg-rollout/helm-charts/codeapi/stg/values.yaml --show-only templates/worker-sandbox-deployment.yaml-> renderedmaxSurge: 0andmaxUnavailable: 1oncodeapi-service-workergit diff --check-> passedStaging evidence behind this fix:
codeapi-service-worker-6f865d45cb-b8gblstayed pending because 0/11 nodes were schedulable: insufficient CPU or memory on eligible nodes, untolerated taints elsewhere, and relevant node groups at max size.Blocking Before Merge
None.