fix(codeapi-chart): support sandbox runner scale to zero#11
Draft
rschlaefli wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Fixes
This PR adds a chart value for CodeAPI deployments where
codeapi-sandbox-runneris scaled from zero by an external scaler such as KEDA.By default the chart still renders the existing service-worker init container that waits for
codeapi-sandbox-runner. For scale-to-zero deployments, set:That lets the service-worker start while the sandbox runner is at zero, so queued/active BullMQ state can wake the runner through the platform scaler.
Branch Coverage
maindc1e56aVerification
Current head:
API Unit Testsondc1e56a-> passed.Service Unit Testsondc1e56a-> passed.helm template codeapi helm/codeapi -n codeapi --set executionManifest.privateKey=dummy --set executionManifest.publicKey=dummy | rg "wait-for-sandbox-runner|wait-for-redis"-> default renders both init containers.helm template codeapi helm/codeapi -n codeapi --set executionManifest.privateKey=dummy --set executionManifest.publicKey=dummy --set workerSandbox.serviceWorker.waitForSandboxRunner=false | rg "wait-for-sandbox-runner|wait-for-redis"-> renderswait-for-redisonly.git diff --check-> pass.Security / Privacy
Blocking Before Merge
Follow-Up After Merge