Guard Coils.dofs_currents against None/bool sentinels (fixes tracing crash on #42)#43
Merged
eduardolneto merged 1 commit intoJul 15, 2026
Conversation
…Tree traversal, fixing 'None is not a valid value for jnp.array' crash in tracing (from_simsopt and from_json paths)
Contributor
|
I will merge this as this does not create any conflict. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small guard for the None is not a valid value for jnp.array crash that #42 still hits during tracing. Coils.dofs_currents now passes a sentinel leaf (None / bool from eqx.partition) straight through instead of doing jnp.array(None) / currents_scale.
Verified on this branch (en/review_eg/examples_fix): from_simsopt + eqx.partition works, and trace_particles_coils_guidingcenter.py runs clean.