Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ rand = { version = "0.10.1", features = ["std_rng"] }
rand_chacha = { version = "0.10.0" }
rayon = "1.10"
regex = "1.10.4"
rlimit = "0.11.0"
rstest = "0.27.0"
rstest_reuse = "0.7.0"
rustc-hash = "2.1.1"
Expand Down Expand Up @@ -394,6 +395,7 @@ runcon = { optional = true, version = "0.13.0", package = "uu_runcon", path = "s

[target.'cfg(unix)'.dev-dependencies]
nix = { workspace = true, features = ["fs", "signal"] }
rlimit = { workspace = true }
rustix = { workspace = true, features = ["net", "process"] }

[build-dependencies]
Expand Down
1 change: 1 addition & 0 deletions src/uu/sort/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ ctrlc = { workspace = true }

[target.'cfg(unix)'.dependencies]
libc = { workspace = true }
rlimit = { workspace = true }

[dev-dependencies]
divan = { workspace = true }
Expand Down
38 changes: 6 additions & 32 deletions src/uu/sort/src/sort.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.

// spell-checker:ignore (misc) kKMGTPEZYRQ HFKJFK Mbdfhn getrlimit Nofile rlim bigdecimal extendedbigdecimal hexdigit behaviour keydef GETFD localeconv foldhash
// spell-checker:ignore (misc) kKMGTPEZYRQ HFKJFK Mbdfhn getrlimit NOFILE rlim bigdecimal extendedbigdecimal hexdigit behaviour keydef GETFD localeconv foldhash
// spell-checker:ignore (misc) uppercased qsort getmonth juin juil

// Although these links don't always seem to describe reality, check out the POSIX and GNU specs:
Expand Down Expand Up @@ -1524,49 +1524,23 @@ fn make_sort_mode_arg(mode: &'static str, short: char, help: String) -> Arg {
.action(ArgAction::SetTrue)
}

#[cfg(all(
unix,
not(any(
target_os = "redox",
target_os = "fuchsia",
target_os = "haiku",
target_os = "solaris",
target_os = "illumos"
))
))]
#[cfg(unix)]
fn get_rlimit() -> UResult<usize> {
use rustix::process::{Resource, getrlimit};
use rlimit::{Resource, getrlimit};

let rlim_cur = getrlimit(Resource::Nofile)
.current
let (rlim_cur, _) = getrlimit(Resource::NOFILE)
.ok_or_else(|| UUsageError::new(2, translate!("sort-failed-fetch-rlimit")))?;

usize::try_from(rlim_cur)
.map_err(|_| UUsageError::new(2, translate!("sort-failed-fetch-rlimit")))
}

#[cfg(all(
unix,
not(any(
target_os = "redox",
target_os = "fuchsia",
target_os = "haiku",
target_os = "solaris",
target_os = "illumos"
))
))]
#[cfg(unix)]
pub(crate) fn fd_soft_limit() -> Option<usize> {
get_rlimit().ok()
}

#[cfg(any(
not(unix),
target_os = "redox",
target_os = "fuchsia",
target_os = "haiku",
target_os = "solaris",
target_os = "illumos"
))]
#[cfg(not(unix))]
pub(crate) fn fd_soft_limit() -> Option<usize> {
None
}
Expand Down
6 changes: 3 additions & 3 deletions tests/by-util/test_cat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.

// spell-checker:ignore Nofile nonewline cmdline setrlimit ELOOP bcde acde
// spell-checker:ignore NOFILE nonewline cmdline setrlimit ELOOP bcde acde

#[cfg(any(target_os = "linux", target_os = "android"))]
use rustix::process::Resource;
use rlimit::Resource;
#[cfg(unix)]
use std::fs::File;
use std::fs::OpenOptions;
Expand Down Expand Up @@ -135,7 +135,7 @@ fn test_closes_file_descriptors() {
"alpha.txt",
"alpha.txt",
])
.limit(Resource::Nofile, 9, 9)
.limit(Resource::NOFILE, 9, 9)
.succeeds();
}

Expand Down
6 changes: 3 additions & 3 deletions tests/by-util/test_cp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.

// spell-checker:ignore (flags) reflink (fs) tmpfs (linux) filefrag rlimit Rlim Nofile clob btrfs neve ROOTDIR USERDIR outfile subvolume uufs xattrs ELOOP
// spell-checker:ignore (flags) reflink (fs) tmpfs (linux) filefrag rlimit Rlim NOFILE clob btrfs neve ROOTDIR USERDIR outfile subvolume uufs xattrs ELOOP
// spell-checker:ignore bdfl hlsl IRWXO IRWXG nconfined matchpathcon libselinux-devel prwx doesnotexist reftests subdirs mksocket srwx dstlink mcstransd

#[cfg(unix)]
Expand Down Expand Up @@ -3448,7 +3448,7 @@ fn test_cp_reflink_insufficient_permission() {
#[cfg(target_os = "linux")]
#[test]
fn test_closes_file_descriptors() {
use rustix::process::Resource;
use rlimit::Resource;

let pid = std::process::id();
let fd_path = format!("/proc/{pid}/fd");
Expand All @@ -3468,7 +3468,7 @@ fn test_closes_file_descriptors() {
.arg("--reflink=auto")
.arg("dir_with_10_files/")
.arg("dir_with_10_files_new/")
.limit(Resource::Nofile, limit_fd, limit_fd)
.limit(Resource::NOFILE, limit_fd, limit_fd)
.succeeds();
}

Expand Down
10 changes: 5 additions & 5 deletions tests/by-util/test_dd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.

// spell-checker:ignore fname, tname, fpath, specfile, testfile, unspec, ifile, ofile, outfile, fullblock, urand, fileio, atoe, atoibm, availible, behaviour, bmax, bremain, btotal, cflags, creat, ctable, ctty, datastructures, doesnt, etoa, fileout, fname, gnudd, iconvflags, iseek, nocache, noctty, noerror, nofollow, nolinks, nonblock, oconvflags, oseek, outfile, parseargs, rlen, rmax, rposition, rremain, rsofar, rstat, sigusr, sigval, wlen, wstat abcdefghijklm abcdefghi nabcde nabcdefg abcdefg fifoname FADV DONTNEED Fsize SIGXFSZ rusage maxrss cdefg ncdefg cdefh
// spell-checker:ignore fname, tname, fpath, specfile, testfile, unspec, ifile, ofile, outfile, fullblock, urand, fileio, atoe, atoibm, availible, behaviour, bmax, bremain, btotal, cflags, creat, ctable, ctty, datastructures, doesnt, etoa, fileout, fname, gnudd, iconvflags, iseek, nocache, noctty, noerror, nofollow, nolinks, nonblock, oconvflags, oseek, outfile, parseargs, rlen, rmax, rposition, rremain, rsofar, rstat, sigusr, sigval, wlen, wstat abcdefghijklm abcdefghi nabcde nabcdefg abcdefg fifoname FADV DONTNEED FSIZE SIGXFSZ rusage maxrss cdefg ncdefg cdefh

use uutests::at_and_ucmd;
use uutests::new_ucmd;
Expand Down Expand Up @@ -2413,14 +2413,14 @@ fn test_count_bytes_with_expanding_block_conv() {
#[test]
#[cfg(all(unix, not(target_vendor = "apple")))]
fn test_stats_are_reported_when_a_write_fails() {
use rustix::process::Resource;
use rlimit::Resource;

const CAP: u64 = 768 * 1024;

let (at, mut ucmd) = at_and_ucmd!();
let result = ucmd
.args(&["if=/dev/zero", "of=capped.bin", "bs=512K", "count=3"])
.limit(Resource::Fsize, CAP, CAP)
.limit(Resource::FSIZE, CAP, CAP)
.ignore_sigxfsz()
.fails();

Expand All @@ -2436,15 +2436,15 @@ fn test_stats_are_reported_when_a_write_fails() {
#[test]
#[cfg(all(unix, not(target_vendor = "apple")))]
fn test_block_stats_are_reported_when_a_write_fails() {
use rustix::process::Resource;
use rlimit::Resource;

const CAP: u64 = 200 * 1024;

let (at, mut ucmd) = at_and_ucmd!();
let result = ucmd
.args(&["conv=block", "cbs=1M", "obs=64K", "of=capped.bin"])
.pipe_in("x\n")
.limit(Resource::Fsize, CAP, CAP)
.limit(Resource::FSIZE, CAP, CAP)
.ignore_sigxfsz()
.fails();

Expand Down
4 changes: 2 additions & 2 deletions tests/by-util/test_expand.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,12 +276,12 @@ fn test_tabs_with_too_large_size() {
)]
#[test]
fn test_large_tab_stop_without_tabs_does_not_allocate() {
use rustix::process::Resource;
use rlimit::Resource;

const AS_LIMIT: u64 = 200 * 1024 * 1024;

new_ucmd!()
.limit(Resource::As, AS_LIMIT, AS_LIMIT)
.limit(Resource::AS, AS_LIMIT, AS_LIMIT)
.arg("--tabs=267672676527678256")
.pipe_in("hello\n")
.succeeds()
Expand Down
2 changes: 1 addition & 1 deletion tests/by-util/test_groups.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.

//spell-checker:ignore coreutil
// spell-checker:ignore coreutil

use uutests::new_ucmd;
use uutests::unwrap_or_return;
Expand Down
6 changes: 3 additions & 3 deletions tests/by-util/test_ls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// file that was distributed with this source code.

// spell-checker:ignore (words) READMECAREFULLY birthtime doesntexist oneline somebackup lrwx somefile somegroup somehiddenbackup somehiddenfile tabsize aaaaaaaa bbbb cccc dddddddd ncccc neee naaaaa nbcdef nfffff dired subdired tmpfs mdir COLORTERM mexe bcdef mfoo timefile
// spell-checker:ignore (words) fakeroot setcap drwxr bcdlps mdangling mentry awith acolons Nofile NOTCAPABLE iproduct newfstatat isox
// spell-checker:ignore (words) fakeroot setcap drwxr bcdlps mdangling mentry awith acolons NOFILE NOTCAPABLE iproduct newfstatat isox

#![allow(
clippy::similar_names,
Expand All @@ -14,7 +14,7 @@

use regex::Regex;
#[cfg(unix)]
use rustix::process::Resource;
use rlimit::Resource;
#[cfg(not(target_os = "openbsd"))]
use std::collections::HashMap;
#[cfg(target_os = "linux")]
Expand Down Expand Up @@ -8130,7 +8130,7 @@ fn test_ls_recursive_no_fd_leak() {
.ucmd()
.arg("-R")
.arg("1")
.limit(Resource::Nofile, 20, 20)
.limit(Resource::NOFILE, 20, 20)
.succeeds()
.no_stderr();
}
Expand Down
4 changes: 2 additions & 2 deletions tests/by-util/test_pr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -563,13 +563,13 @@ fn test_large_page_width_does_not_panic() {
ignore = "WASI: wasmtime itself needs more memory than the guest's rlimit allows"
)]
fn test_offset_large_value_does_not_abort_under_memory_limit() {
use rustix::process::Resource;
use rlimit::Resource;
use std::process::Stdio;

const AS_LIMIT: u64 = 200 * 1024 * 1024;

new_ucmd!()
.limit(Resource::As, AS_LIMIT, AS_LIMIT)
.limit(Resource::AS, AS_LIMIT, AS_LIMIT)
.set_stdout(Stdio::null())
.args(&["-t", "-o", "999999999"])
.pipe_in("hi\n")
Expand Down
20 changes: 9 additions & 11 deletions tests/by-util/test_sort.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.

// spell-checker:ignore (words) ints (linux) Nofile dfgi abmon avril
// spell-checker:ignore (words) ints (linux) NOFILE dfgi abmon avril

#![allow(clippy::cast_possible_wrap)]

Expand All @@ -13,6 +13,9 @@ use std::fmt::Write as FmtWrite;
use std::process::Command;
use std::time::Duration;

#[cfg(target_os = "linux")]
use rlimit::Resource;

use uutests::at_and_ucmd;
use uutests::new_ucmd;
use uutests::util::TestScenario;
Expand Down Expand Up @@ -1788,14 +1791,13 @@ fn test_merge_batch_size() {
// #[cfg(any(target_os = "linux", target_os = "android"))]
#[cfg(target_os = "linux")]
fn test_merge_batch_size_with_limit() {
use rustix::process::Resource;
// Currently need...
// 3 descriptors for stdin, stdout, stderr
// 2 descriptors for CTRL+C handling logic (to be reworked at some point)
// 2 descriptors for the input files (i.e. batch-size of 2).
let limit_fd = 3 + 2 + 2;
new_ucmd!()
.limit(Resource::Nofile, limit_fd, limit_fd)
.limit(Resource::NOFILE, limit_fd, limit_fd)
.arg("--batch-size=2")
.arg("-m")
.arg("--unique")
Expand All @@ -1813,13 +1815,12 @@ fn test_merge_batch_size_with_limit() {
// TODO(#7542): Re-enable on Android once we figure out why setting limit is broken.
#[cfg(target_os = "linux")]
fn test_batch_size_above_fd_limit_is_rejected() {
use rustix::process::Resource;
// Only stdin, stdout and stderr are unavailable for merge inputs, so the
// largest acceptable --batch-size is the soft limit minus 3, here 27 - 3.
let limit_fd = 27;
let (at, mut ucmd) = at_and_ucmd!();
at.write("gamma.txt", "delta\nalpha\n");
ucmd.limit(Resource::Nofile, limit_fd, limit_fd)
ucmd.limit(Resource::NOFILE, limit_fd, limit_fd)
.arg("--batch-size=31")
.arg("gamma.txt")
.fails_with_code(2)
Expand All @@ -1831,12 +1832,11 @@ fn test_batch_size_above_fd_limit_is_rejected() {
#[test]
#[cfg(target_os = "linux")]
fn test_batch_size_at_fd_limit_is_accepted() {
use rustix::process::Resource;
let limit_fd = 27;
let (at, mut ucmd) = at_and_ucmd!();
at.write("gamma.txt", "delta\nalpha\n");
// 24 is the largest value the limit above allows, and sorting must still happen.
ucmd.limit(Resource::Nofile, limit_fd, limit_fd)
ucmd.limit(Resource::NOFILE, limit_fd, limit_fd)
.arg("--batch-size=24")
.arg("gamma.txt")
.succeeds()
Expand All @@ -1846,7 +1846,6 @@ fn test_batch_size_at_fd_limit_is_accepted() {
#[test]
#[cfg(target_os = "linux")]
fn test_merge_more_files_than_fd_limit() {
use rustix::process::Resource;
let (at, mut ucmd) = at_and_ucmd!();
// 40 single-line files cannot all be open at once with a soft limit of 24,
// so sort has to merge them in several batches through temporary files.
Expand All @@ -1862,7 +1861,7 @@ fn test_merge_more_files_than_fd_limit() {
writeln!(expected, "{i:02}").unwrap();
}
let limit_fd = 24;
ucmd.limit(Resource::Nofile, limit_fd, limit_fd)
ucmd.limit(Resource::NOFILE, limit_fd, limit_fd)
.arg("-m")
.args(&names)
.succeeds()
Expand All @@ -1872,7 +1871,6 @@ fn test_merge_more_files_than_fd_limit() {
#[test]
#[cfg(target_os = "linux")]
fn test_more_files_than_fd_limit() {
use rustix::process::Resource;
let (at, mut ucmd) = at_and_ucmd!();
// The inputs are read one after another, so sorting must not need more open
// file descriptors than the soft limit allows, no matter how many inputs there are.
Expand All @@ -1888,7 +1886,7 @@ fn test_more_files_than_fd_limit() {
writeln!(expected, "{i:02}").unwrap();
}
let limit_fd = 24;
ucmd.limit(Resource::Nofile, limit_fd, limit_fd)
ucmd.limit(Resource::NOFILE, limit_fd, limit_fd)
.args(&names)
.succeeds()
.stdout_only(expected);
Expand Down
Loading
Loading