Skip to content

chgrp: strip error when changing group of file fails #14403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Devel08 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

chgrp: strip error when changing group of file fails #14403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/uucore/src/lib/features/perms.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,14 @@ pub fn wrap_chown<P: AsRef<Path>>(
VerbosityLevel::Silent => (),
level => {
out = format!(
"changing {} of {}: {e}",

@anastygnome anastygnome Sep 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also add localised messages for this.

@Devel08 Devel08 Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, good catch, either error-changing-group-failed and error-changing-ownership-failed or a single error-change-failed with 3 strings, we can do that after this is merged :)

@sylvestre sylvestre Sep 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is still draft

@Devel08 Devel08 Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylvestre can be merged now

"changing {} of {}: {}",
if verbosity.groups_only {
"group"
} else {
"ownership"
},
path.quote(),
strip_errno(&e),
);
if level == VerbosityLevel::Verbose {
out = if verbosity.groups_only {
Expand Down
4 changes: 2 additions & 2 deletions tests/by-util/test_chgrp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ fn test_reference() {
.arg("/etc")
.fails()
// group name can differ, so just check the first part of the message
.stderr_contains("chgrp: changing group of '/etc': Operation not permitted (os error 1)\nfailed to change group of '/etc' from ");
.stderr_contains("chgrp: changing group of '/etc': Operation not permitted\nfailed to change group of '/etc' from ");
}

#[test]
Expand Down Expand Up @@ -277,7 +277,7 @@ fn test_big_p() {
.arg("/proc/self/cwd")
.fails()
.stderr_contains(
"chgrp: changing group of '/proc/self/cwd': Operation not permitted (os error 1)\n",
"chgrp: changing group of '/proc/self/cwd': Operation not permitted\n",
);
}
}
Expand Down
Loading